This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [python][patch] Add GDB Parameters functionality
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Phil Muldoon <pmuldoon at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 26 Apr 2010 20:55:37 +0300
- Subject: Re: [python][patch] Add GDB Parameters functionality
- References: <4BD592D9.1070801@redhat.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Mon, 26 Apr 2010 14:19:21 +0100
> From: Phil Muldoon <pmuldoon@redhat.com>
>
> This patch brings over GDB Parameter functionality from the Archer
> project/repository. This functionality remains largely the same; I've
> reintroduced some functionality back into py-cmd that was stripped
> from the last FSF import, and fixed several bugs related to enum
> parameters. It also introduces a new testsuite.
Thanks.
> 2010-04-26 Phil Muldoon <pmuldoon@redhat.com>
> Tom Tromey <tromey@redhat.com>
> Thiago Jung Bauermann <bauerman@br.ibm.com>
>
> * gdb.texinfo (Parameters In Python): New Node.
A few minor comments about this part.
> +You can implement new @value{GDBN} parameters using Python.
This should have a cross-reference to where GDB parameters are
described in the manual (in the "Help" node). Alternatively, add here
a short explanation what are they. (The name is unfortunate; I'd
prefer "options" or "settings", but since we already use "parameters",
so be it.)
> +@var{name} is the name of the new parameter. If @var{name} consists
> +of multiple words, then the initial words are looked for as prefix
> +commands.
An example here would help greatly. I would also suggest to drop the
"commands" part, because we are not talking about commands here.
> +@item PARAM_STRING
> +The value is a string. When the user modifies the string, escapes are
> +translated.
It's not clear what escapes are meant here, and what translation does
to them. I suggest an example or a few words of clarification.
> +@findex PARAM_FILENAME
> +@findex gdb.PARAM_FILENAME
> +@item PARAM_FILENAME
> +The value is a filename (a string).
Is that just a string, or is it somehow different from a string? If
the latter, let's tell what is the difference.
Okay with these changes.
Maybe we should consider mentioning this in NEWS.
Thanks.