This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Gracefully handle not being able to access a DWARF register number
- From: Tom Tromey <tromey at redhat dot com>
- To: Matthew Gretton-Dann <matthew dot gretton-dann at arm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 26 Apr 2010 14:06:34 -0600
- Subject: Re: [PATCH] Gracefully handle not being able to access a DWARF register number
- References: <1272295674.16160.23.camel@e102111-lin.cambridge.arm.com>
- Reply-to: tromey at redhat dot com
>>>>> "Matthew" == Matthew Gretton-Dann <matthew.gretton-dann@arm.com> writes:
Matthew> The attached patch changes these internal errors into warnings, and
Matthew> tries to return something sensible to the user.
Why a warning and not an error?
It seems to me that an error is preferable to returning incorrect
information.
Matthew> Please could someone review and comment on the patch, and then if this
Matthew> is approved can they please commit it as I don't have commit rights.
Do you have copyright assignment paperwork in place?
Matthew> + warning (_("Unable to access DWARF register number %" BFD_VMA_FMT "d"),
Matthew> + p->v.expr.value);
I think there is some other way to print a CORE_ADDR, but I forget what
it is. BFD_VMA_FMT seems suspect, just because it is not used anywhere
else in gdb.
Tom