This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [vxworks 02/14] New command_post observer.


> There are a lot of calls to execute_command that occur in batch-like
> places.  For example, this is called from Python, I think it is called
> from "commands" scripts and "define" scripts, etc.
> 
> So if your goal is to have it just emit info at some stopping point, it
> seems to me that it would be better to have an observer just before a
> prompt is emitted.
> 
> I didn't read every patch in detail, so I didn't see where this is used.
> Maybe the above doesn't matter.

Either way would work, as far as I am concerned.  The purpose is to
inform the user that the context (partition) has changed.  I have
a tiny preference towards having consistent output, if we can, with
commands executed from the prompt and commands executed from elsewhere
such as user-defined commands for instance. But that preference really
has no additional technical merit that I can think of, so I'm happy to
change the observer to use something triggered just before printing
the command prompt (btw: it does not matter in this case, but I believe
that the prompt also gets printed as "> " while entering a canned
sequence of command).

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]