This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: New ARI warning Sat Apr 24 01:55:22 UTC 2010
- From: Joel Brobecker <brobecker at adacore dot com>
- To: gdb-patches at sourceware dot org
- Date: Tue, 27 Apr 2010 09:40:49 -0700
- Subject: Re: New ARI warning Sat Apr 24 01:55:22 UTC 2010
- References: <20100424015523.GA5071@sourceware.org>
Hello,
> gdb/ppc-linux-nat.c:1511:static inline int
> 1101a1101
> > gdb/python/py-auto-load.c:263: gettext: trailing new line: A message should not have a trailing new line
> gdb/python/py-auto-load.c:263: warning (_("%s (referenced in %s): %s\n"),
I fixed these two...
> 1331a1332
> > gdb/solib-svr4.c:295: code: UCASE function: Function name is uppercase.
> gdb/solib-svr4.c:295:IGNORE_FIRST_LINK_MAP_ENTRY (struct so_list *so)
This one, on the other hand, is easy to fix, but requires discussion.
It seems to the current style for this sort of routine in solib-svr4.c.
I don't know why we decided to name these functions using all uppercase
letters, but it's apparently against the ARI.
Examples of all upper-case functions: LM_ADDR_FROM_LINK_MAP,
HAS_LM_DYNAMIC_FROM_LINK_MAP, LM_DYNAMIC_FROM_LINK_MAP, LM_ADDR_CHECK,
etc.
It's really easy to change their name, but maybe there is a reason other
than historical for them being all uppercase (maybe they were macros).
Something to look at during a rainy day...
--
Joel