This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PING] [RFC/Windows] Remember last tlb type for re-use in windows_get_tlb_type



> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Christopher Faylor
> Envoyé?: Friday, April 30, 2010 4:54 PM
> À?: gdb-patches@sourceware.org; Pierre Muller
> Objet?: Re: [PING] [RFC/Windows] Remember last tlb type for re-use in
> windows_get_tlb_type
> 
> On Fri, Apr 30, 2010 at 12:24:26AM +0200, Pierre Muller wrote:
> >Nobody reacted to this:
> >http://sourceware.org/ml/gdb-patches/2010-04/msg00552.html
> >
> >It helps avoid some unnecessary recomputation.
> 
> Looks ok but is this computation really so onerous that we need to add
> the extra code?

  Each time you dereference $_tlb
you recreate the same bunch of internal types
leaving the other types in the wild...
  This looses computation time and memory.
  Imagine that you use a long script with
a breakpoint that has commands associated
that print $_tlb.current_seh to check if the current structured exception
handler has changed....

  Honestly, I don't know if it can become a big problem,
but I thought it would be better to avoid it.
  I first was thinking about removing old values,
but I didn't find a clean way to remove the type and all its
dependents...

Pierre Muller



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]