This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PING] [RFC/Windows] Remember last tlb type for re-use in windows_get_tlb_type


>>>>> "cgf" == Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org> writes:

cgf> Attaching them to gdbarch would make them permanent for the life of the
cgf> debugging session right?  That seems better but I agree that, in practice,
cgf> this is probably just as good.

Yeah, but it would fix a leak that is latent even with Pierre's latest
patch: if you use the TLB, switch arches, use it again, then switch
back, and use it a third time, then that third time will recreate the
types.  If the types were attached to the gdbarch, then the third use
would reuse the types created the first time through.

My guess is that this sort of scenario is rare.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]