Re: [RFA] Fix display of entry point address

[Doug Evans <dje at google dot com>]

On Fri, Apr 30, 2010 at 9:01 AM, Matthew Gretton-Dann
<matthew.gretton-dann@arm.com> wrote:
> Hi,
>
> Please can someone review the attached patch?
>
> When displaying the entry point to a file (for instance as part of the
> output of `info files') gdb prints the raw address it has calculated.
> This is misleading on some platforms (notably on ARM when the entry
> point is to a Thumb-state function) as the address will contain
> additional information.
>
> For example (from the break-entry.exp test):
>
> (gdb) file /home/mgretton/gdb/build/gdb/testsuite/gdb.base/break-entry
> Reading symbols from /home/mgretton/gdb/build/gdb/testsuite/gdb.base/break-entry...(no debugging symbols found)...done.
> (gdb) info files
> Symbols from "/home/mgretton/gdb/build/gdb/testsuite/gdb.base/break-entry".
> Local exec file:
> ? ? ? ?`/home/mgretton/gdb/build/gdb/testsuite/gdb.base/break-entry', file type elf32-littlearm.
> ? ? ? ?Entry point: 0x8171
>
> This is confusing as trying to set a breakpoint at 0x8171 causes a
> warning like the following to be displayed:
>
> (gdb) break *0x8171
> warning: Breakpoint address adjusted from 0x00008171 to 0x00008170.
> Breakpoint 1 at 0x8170
>
> The attached patch changes gdb's behaviour to strip the arch specific
> bits off the entry point before displaying it.
>
> A testsuite run shows no regressions, and the gdb.base/break-entry.exp
> test now passes in its entirety.
>
> Suggested ChangeLog entry:
>
> 2010-04-30 ?Matthew Gretton-Dann ?<matthew.gretton-dann@arm.com>
>
> ? ? ? ?* exec.c (print_section_info): Display entry point without arch
> ? ? ? ?specific parts.
>
> Thanks,
>
> Matt
>
> --
> Matthew Gretton-Dann
> Principal Engineer - Tools, PD Software
> ARM Limited
>

Hi.  I'd give it a day to see if someone else comments, but the patch
is ok to me.