This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] frame-unwind, gnu-v2-abi, cp-support, cp-namespace, trad-frame, tramp-frame.c: remove unused vars.
- From: Michael Snyder <msnyder at vmware dot com>
- To: "tromey at redhat dot com" <tromey at redhat dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 07 May 2010 11:30:56 -0700
- Subject: Re: [patch] frame-unwind, gnu-v2-abi, cp-support, cp-namespace, trad-frame, tramp-frame.c: remove unused vars.
- References: <4BE369A3.9080107@vmware.com> <m3wrvffvzz.fsf@fleche.redhat.com>
Tom Tromey wrote:
Michael> - CORE_ADDR pc = get_frame_pc (this_frame);
I am not completely sure this is safe. Maybe get_frame_pc can throw an
exception.
I thought about that, but if the function call is there
solely because of some side effect it can have, that's
pretty fishy too.
I'm willing to put it back if that's what is thought best...
- References:
- [patch] frame-unwind, gnu-v2-abi, cp-support, cp-namespace, trad-frame, tramp-frame.c: remove unused vars.
- Re: [patch] frame-unwind, gnu-v2-abi, cp-support, cp-namespace, trad-frame, tramp-frame.c: remove unused vars.