This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfa] gdb.base/volatile.exp / varargs.exp: replace send_gdb with gdb_test


> >Just wondering why you added the "testfile" at the end of the test
> >description?
> 
> I copied it from an existing test.  My guess is that it
> uniquifies the output, which otherwise would be identical
> for a bunch of tests.

You mean, from another testcase? The test description is the combination
of the testcase name (.exp file) and test name (in our case, the command).
I think I double-checked in this specific testcase that the command was
used only once, so the uniqueness should be guaranteed.

> >>+gdb_test "set print sevenbit-strings" ""
> >>+gdb_test "set print address off" ""
> >>+gdb_test "set width 0" ""
> 
> Checking....  it seems that we have instances of at least four
> different styles for these three specific statements.  I will
> try to homogenize them.

Just a thought, because I haven't really looked at what the "four
different styles" are, but I agree with Pedro when he says that
we should have separate patches for each step. If the homogenization
is not a mechanical step, perhaps it would be a good candidate for
a followup test?

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]