This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PING] [RFC] Extend gdb_ari.sh with ARI_OFF/ARI_ON


>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:

Pierre>  Noone reacted to that proposal yet...

Sorry about that.

Pierre>   We this new patch, we can disable all 8 warnings of windows-nat.c
Pierre> by adding just two lines:
Pierre> /* ARI_OFF: editCase function */
Pierre> and
Pierre> /* ARI_ON: editCase function */
Pierre> at the start and the end of the list of
Pierre> bad_MixedFunctionNameSameAsWindowsAPI
Pierre> list.

Pierre>   Comments?

I think this kind of mechanism is too obscure.  The markers may be very
far from the place that one is editing.

Do we really need this particular ARI rule at all?  This sort of problem
is usually caught by patch review... and if it an instance is missed, it
doesn't have any impact on code quality.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]