Re: [RFA] gdb.gdb/*.exp send_gdb vs. gdb_test

[Michael Snyder <msnyder at vmware dot com>]

Joel Brobecker wrote:
> > 2010-05-25  Michael Snyder  <msnyder@vmware.com>
> >
> > 	* gdb.gdb/complaints.exp: Replace send_gdb with gdb_test.
> > 	* gdb.gdb/selftest.exp: Replace send_gdb with gdb_test.
> > 	* gdb.gdb/xfullpath.exp: Replace send_gdb with gdb_test.
>
> Same question as before: Can you double-check that gdb_test cannot
> be used in the cases below? If not, OK to commit.
>
> >      # Add a second complaint, expect it
> > -    send_gdb "call complaint (&symfile_complaints, \"serial line 2\")\n"
> > -    gdb_expect {
> > +    gdb_test_multiple "call complaint (&symfile_complaints, \"serial line 2\")" "serial line 2" {
> >  	-re "serial line 2...$gdb_prompt " {

Can't use gdb_test because the usual CR/LF are missing from in front of 
$gdb_prompt.

> >  	    pass "serial line 2"
> >  	}
> > -	"$gdb_prompt" {
> > -	    fail "serial line 2"
> > -	}
> > -	timeout {
> > -	    fail "serial line 2 (timeout)"
> > -	}
>
> Can we use gdb_test here?
>
> > -    send_gdb "call complaint (&symfile_complaints, \"short line 1\")\n"
> > -    gdb_expect {
> > +    gdb_test_multiple "call complaint (&symfile_complaints, \"short line 1\")" "short line 1" {
> >  	-re "short line 1...$gdb_prompt " {

Ditto.

> >  	    pass "short line 1"
>
> Ditto?
>
> >      # Add a second complaint, expect it
> > -    send_gdb "call complaint (&symfile_complaints, \"short line 2\")\n"
> > -    gdb_expect {
> > +    gdb_test_multiple "call complaint (&symfile_complaints, \"short line 2\")" "short line 2" {
>
> Ditto again.

Ditto again.