This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[obv] testsuite: gdb.base/sepdebug.exp racy FAIL


Hi,

there was an obvious excessive newline causing (very) occasional false FAIL.

Checked-in.

Tested on x86_64-fedora13-linux-gnu.


Thanks,
Jan


 (gdb) PASS: gdb.base/sepdebug.exp: set to-be-silent break bp_location1
 commands 25
 Type commands for breakpoint(s) 25, one per line.
 End with a line saying just "end".
 >silent
 >end
 (gdb) PASS: gdb.base/sepdebug.exp: set silent break bp_location1
 info break 25
 Num     Type           Disp Enb Address    What
 25      breakpoint     keep y   0x080484d3 in main at gdb/testsuite/gdb.base/sepdebug.c:95
         silent
 (gdb) PASS: gdb.base/sepdebug.exp: info silent break bp_location1
 
 Num     Type           Disp Enb Address    What
 25      breakpoint     keep y   0x080484d3 in main at gdb/testsuite/gdb.base/sepdebug.c:95
         silent
-(gdb) continue
+(gdb) FAIL: gdb.base/sepdebug.exp: hit silent break bp_location1
+continue
 Continuing.
-(gdb) PASS: gdb.base/sepdebug.exp: hit silent break bp_location1
+(gdb) FAIL: gdb.base/sepdebug.exp: stopped for silent break bp_location1
 bt


http://sourceware.org/ml/gdb-cvs/2010-05/msg00242.html

--- src/gdb/testsuite/ChangeLog	2010/05/27 23:44:51	1.2289
+++ src/gdb/testsuite/ChangeLog	2010/05/28 17:57:44	1.2290
@@ -1,3 +1,8 @@
+2010-05-28  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	* gdb.base/sepdebug.exp (info silent break bp_location1): Fix racy
+	excessive newline.
+
 2010-05-27  Michael Snyder  <msnyder@msnyder-server.eng.vmware.com>
 
 	* gdb.base/break.exp: Replace uses of send_gdb / gdb_expect.
--- src/gdb/testsuite/gdb.base/sepdebug.exp	2010/05/27 23:44:51	1.26
+++ src/gdb/testsuite/gdb.base/sepdebug.exp	2010/05/28 17:57:44	1.27
@@ -388,7 +388,7 @@
   timeout {fail "(timeout) set silent break bp_location1"}
 }
 
-gdb_test "info break $expect_out(1,string)\n" \
+gdb_test "info break $expect_out(1,string)" \
     "\[0-9\]*\[ \t\]*breakpoint.*:$bp_location1\r\n\[ \t\]*silent.*" \
     "info silent break bp_location1"
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]