[patch 2/2] testsuite: dw2-ref-missing-frame for PR python/11407

[Jan Kratochvil <jan dot kratochvil at redhat dot com>]

Hi,

Phil Muldoon is going to post tomorrow a fix for PR python/11407.  Extended
the testcase to support it, it is KFAILed now.

	bt full
	#0  0x00000000004004b8 in func_nofb ()
		func_nofb_var = Could not find the frame base for "func_nofb".
	(gdb) KFAIL: gdb.dwarf2/dw2-ref-missing-frame.exp: func_nofb backtrace (PRMS: python/11407)
->
	bt full
	#0  0x00000000004004b8 in func_nofb ()
		func_nofb_var = <error reading variable func_nofb_var (Could not find the frame base for "func_nofb".)>
	#1  0x00000000004004d4 in main () at ./gdb.dwarf2/dw2-ref-missing-frame-main.c:26
		main_var = 1
	(gdb) KPASS: gdb.dwarf2/dw2-ref-missing-frame.exp: func_nofb backtrace (PRMS python/11407)

Tested on {x86_64,x86_64-m32}-fedora13-linux-gnu.


Thanks,
Jan


2010-06-23  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* gdb.dwarf2/dw2-ref-missing-frame-func.c: New file.
	* gdb.dwarf2/dw2-ref-missing-frame.S: Use cu_text_start and cu_text_end.
	Split main into func_nofb and func_loopfb dropping NO_FRAME_BASE.
	* gdb.dwarf2/dw2-ref-missing-frame.exp: Remove variables sources,
	executable_nofb and executable_fb.  New variables srcsfile, objsfile,
	srcfuncfile, objfuncfile, srcmainfile, objmainfile, executable and
	binfile.  Call gdb_compile with clean_restart twice.
	(func_nofb print, func_nofb backtrace, func_loopfb print)
	(func_loopfb backtrace): New.  Use KFAIL python/11407.

--- /dev/null
+++ b/gdb/testsuite/gdb.dwarf2/dw2-ref-missing-frame-func.c
@@ -0,0 +1,46 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+   Copyright 2010 Free Software Foundation, Inc.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+asm (".globl cu_text_start");
+asm ("cu_text_start:");
+
+asm (".globl func_nofb_start");
+asm ("func_nofb_start:");
+
+void
+func_nofb (void)
+{
+  /* int func_nofb_var; */
+}
+
+asm (".globl func_nofb_end");
+asm ("func_nofb_end:");
+
+asm (".globl func_loopfb_start");
+asm ("func_loopfb_start:");
+
+void
+func_loopfb (void)
+{
+  /* int func_loopfb_var; */
+}
+
+asm (".globl func_loopfb_end");
+asm ("func_loopfb_end:");
+
+asm (".globl cu_text_end");
+asm ("cu_text_end:");
--- a/gdb/testsuite/gdb.dwarf2/dw2-ref-missing-frame-main.c
+++ b/gdb/testsuite/gdb.dwarf2/dw2-ref-missing-frame-main.c
@@ -15,16 +15,16 @@
    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
-asm (".globl main_start");
-asm ("main_start:");
+extern void func_nofb (void);
+extern void func_loopfb (void);
 
 int
 main (void)
 {
-  /* int main_var; */
+  int main_var = 1;
+
+  func_nofb ();
+  func_loopfb ();
 
   return 0;
 }
-
-asm (".globl main_end");
-asm ("main_end:");
--- a/gdb/testsuite/gdb.dwarf2/dw2-ref-missing-frame.S
+++ b/gdb/testsuite/gdb.dwarf2/dw2-ref-missing-frame.S
@@ -28,8 +28,8 @@
 
 	/* CU die */
 	.uleb128 1				/* Abbrev: DW_TAG_compile_unit */
-	.4byte	main_end			/* DW_AT_high_pc */
-	.4byte	main_start			/* DW_AT_low_pc */
+	.4byte	cu_text_end			/* DW_AT_high_pc */
+	.4byte	cu_text_start			/* DW_AT_low_pc */
 	.ascii	"file1.txt\0"			/* DW_AT_name */
 	.ascii	"GNU C 3.3.3\0"			/* DW_AT_producer */
 	.byte	1				/* DW_AT_language (C) */
@@ -40,20 +40,33 @@
 	.byte		4			/* DW_AT_byte_size */
 	.byte		5			/* DW_AT_encoding */
 
-	/* func */
-	.uleb128	6			/* Abbrev: DW_TAG_subprogram */
-	.ascii		"main\0"		/* DW_AT_name */
-	.4byte		main_start		/* DW_AT_low_pc */
-	.4byte		main_end		/* DW_AT_high_pc */
-#ifndef NO_FRAME_BASE
+	/* func_nofb */
+	.uleb128	5			/* Abbrev: DW_TAG_subprogram (no fb) */
+	.ascii		"func_nofb\0"		/* DW_AT_name */
+	.4byte		func_nofb_start		/* DW_AT_low_pc */
+	.4byte		func_nofb_end		/* DW_AT_high_pc */
+
+	.uleb128	7			/* Abbrev: DW_TAG_variable (location) */
+	.ascii		"func_nofb_var\0"	/* DW_AT_name */
+	.byte		2f - 1f			/* DW_AT_location */
+1:	.byte		0x91			/*   DW_OP_fbreg */
+	.sleb128	0			/*   0 */
+2:	.4byte		.Ltype_int-.Lcu1_begin	/* DW_AT_type */
+
+	.byte		0			/* End of children of func */
+
+	/* func_loopfb */
+	.uleb128	6			/* Abbrev: DW_TAG_subprogram (loop fb) */
+	.ascii		"func_loopfb\0"		/* DW_AT_name */
+	.4byte		func_loopfb_start	/* DW_AT_low_pc */
+	.4byte		func_loopfb_end		/* DW_AT_high_pc */
 	.byte		2f - 1f			/* DW_AT_frame_base */
 1:	.byte		0x91			/*   DW_OP_fbreg */
 	.sleb128	0			/*   0 */
 2:
-#endif
 
 	.uleb128	7			/* Abbrev: DW_TAG_variable (location) */
-	.ascii		"main_var\0"		/* DW_AT_name */
+	.ascii		"func_loopfb_var\0"	/* DW_AT_name */
 	.byte		2f - 1f			/* DW_AT_location */
 1:	.byte		0x91			/*   DW_OP_fbreg */
 	.sleb128	0			/*   0 */
@@ -96,8 +109,20 @@
 	.byte		0x0			/* Terminator */
 	.byte		0x0			/* Terminator */
 
+	.uleb128	5			/* Abbrev code */
+	.uleb128	0x2e			/* DW_TAG_subprogram (no fb) */
+	.byte		1			/* has_children */
+	.uleb128	0x3			/* DW_AT_name */
+	.uleb128	0x8			/* DW_FORM_string */
+	.uleb128	0x11			/* DW_AT_low_pc */
+	.uleb128	0x1			/* DW_FORM_addr */
+	.uleb128	0x12			/* DW_AT_high_pc */
+	.uleb128	0x1			/* DW_FORM_addr */
+	.byte		0x0			/* Terminator */
+	.byte		0x0			/* Terminator */
+
 	.uleb128	6			/* Abbrev code */
-	.uleb128	0x2e			/* DW_TAG_subprogram */
+	.uleb128	0x2e			/* DW_TAG_subprogram (loop fb) */
 	.byte		1			/* has_children */
 	.uleb128	0x3			/* DW_AT_name */
 	.uleb128	0x8			/* DW_FORM_string */
@@ -105,10 +130,8 @@
 	.uleb128	0x1			/* DW_FORM_addr */
 	.uleb128	0x12			/* DW_AT_high_pc */
 	.uleb128	0x1			/* DW_FORM_addr */
-#ifndef NO_FRAME_BASE
 	.uleb128	0x40			/* DW_AT_frame_base */
 	.uleb128	0xa			/* DW_FORM_block1 */
-#endif
 	.byte		0x0			/* Terminator */
 	.byte		0x0			/* Terminator */
 
--- a/gdb/testsuite/gdb.dwarf2/dw2-ref-missing-frame.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-ref-missing-frame.exp
@@ -25,25 +25,38 @@ if {![istarget *-*-linux*]
 }
 
 set testfile "dw2-ref-missing-frame"
-set sources [list ${testfile}-main.c ${testfile}.S]
+set srcsfile ${testfile}.S
+set objsfile ${objdir}/${subdir}/${testfile}.o
+set srcfuncfile ${testfile}-func.c
+set objfuncfile ${objdir}/${subdir}/${testfile}-func.o
+set srcmainfile ${testfile}-main.c
+set objmainfile ${objdir}/${subdir}/${testfile}-main.o
+set executable ${testfile}
+set binfile ${objdir}/${subdir}/${executable}
 
-# First try referencing DW_AT_frame_base which is not defined.
-set executable_nofb ${testfile}-nofb
-if { [prepare_for_testing ${testfile}.exp $executable_nofb $sources {nodebug additional_flags=-DNO_FRAME_BASE}] } {
+if { [gdb_compile "${srcdir}/${subdir}/${srcsfile}" $objsfile object {}] != ""
+     || [gdb_compile "${srcdir}/${subdir}/${srcfuncfile}" $objfuncfile object {}] != ""
+     || [gdb_compile "${srcdir}/${subdir}/${srcmainfile}" $objmainfile object {debug}] != ""
+     || [gdb_compile "$objsfile $objfuncfile $objmainfile" $binfile executable {}] != "" } {
     return -1
 }
 
-if [runto_main] {
-    gdb_test "p main_var" {Could not find the frame base for "main".}
+clean_restart $executable
+
+# First try referencing DW_AT_frame_base which is not defined.
+if [runto func_nofb] {
+    gdb_test "p func_nofb_var" {Could not find the frame base for "func_nofb".} "func_nofb print"
+    setup_kfail python/11407 "*-*-*"
+    gdb_test "bt full" " in main .* main_var = 1" "func_nofb backtrace"
 }
 
+# GDB could have crashed.
+clean_restart $executable
+
 # And now try referencing DW_AT_frame_base defined using a self-reference
 # (DW_OP_fbreg).
-set executable_fb ${testfile}-fb
-if { [prepare_for_testing ${testfile}.exp $executable_fb $sources {nodebug}] } {
-    return -1
-}
-
-if [runto_main] {
-    gdb_test "p main_var" "DWARF-2 expression error: Loop detected .*"
+if [runto func_loopfb] {
+    gdb_test "p func_loopfb_var" "DWARF-2 expression error: Loop detected .*" "func_loopfb print"
+    setup_kfail python/11407 "*-*-*"
+    gdb_test "bt full" " in main .* main_var = 1" "func_loopfb backtrace"
 }