This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: ping: [patch 4/6] testsuite: Unify to lib/prelink-support.exp
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 5 Jul 2010 10:34:52 -0700
- Subject: Re: ping: [patch 4/6] testsuite: Unify to lib/prelink-support.exp
- References: <20100329161753.GC2940@host0.dyn.jankratochvil.net> <20100609150923.GD7183@host0.dyn.jankratochvil.net> <20100629215558.GU2595@adacore.com> <20100704101823.GD6875@host0.dyn.jankratochvil.net>
> gdb/testsuite/
> 2010-07-04 Jan Kratochvil <jan.kratochvil@redhat.com>
> Joel Brobecker <brobecker@adacore.com>
>
> * gdb.base/attach-pie-misread.exp: Load prelink-support.exp. Replace
> build_executable by build_executable_own_libs. Replace "prelink -R"
> execution by a call of prelink_yes. Comment why "prelink -r" needs no
> change.
> * gdb.base/break-interp.exp: Load prelink-support.exp. Rename calls of
> copy to file_copy. Move setting opts --dynamic-linker and -rpath,
> mkdir $dir and ldd its parsing and copying to lib/prelink-support.exp.
> Replace build_executable by build_executable_own_libs's function
> build_executable_own_libs.
> (prelinkNO): Create new stub to call prelink_no.
> (prelinkYES): Create new stub to call prelink_yes.
> (test_attach): Rename calls of copy to file_copy.
> (section_get, prelinkNO_run, prelinkNO, prelinkYES, symlink_resolve)
> (copy): Move to ...
> * lib/prelink-support.exp: ... a new file. Rename prelinkNO to
> prelink_no, prelinkYES to prelink_yes, copy to file_copy.
> * gdb.base/prelink.exp: Disable testcase also for is_remote and
> skip_shlib_tests. Load prelink-support.exp. Replace gdb_compile with
> special flags by gdb_compile_shlib. Replace second gdb_compile by
> build_executable_own_libs. Replace "prelink -R" execution by a call of
> prelink_yes. Replace "prelink -u" and second "prelink -R" execution by
> a second call of prelink_yes. Replace restart commands by
> clean_restart.
> (prelink): Rename to ...
> (seen displacement message): ... this test. Extend its expectation
> strictness.
OK to commit.
> + # For normal prelink (prelink_yes call) we need to supply $prelink_args.
> + # For the prelink `-r' option below $prelink_args is not required.
> + # Moreover if it would be used the problem would not longer be reproducible
> + # as the libraries would also get relocated.
Minor editorial changes (mostly adding comas)...
# For normal prelink (prelink_yes call), we need to supply $prelink_args.
# For the prelink `-r' option below, $prelink_args is not required.
# Moreover, if it was used, the problem would not longer be reproducible
# as the libraries would also get relocated.
--
Joel