This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 2/3] Change cplus_specific to an alocated struct
- From: Tom Tromey <tromey at redhat dot com>
- To: sami wagiaalla <swagiaal at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 13 Jul 2010 11:24:21 -0600
- Subject: Re: [patch 2/3] Change cplus_specific to an alocated struct
- References: <4BFD4230.3030600@redhat.com> <m34ohdlap4.fsf@fleche.redhat.com> <4C167FCA.7030300@redhat.com> <m3pqzrucpg.fsf@fleche.redhat.com> <4C3B598F.9000403@redhat.com>
>>>>> "Sami" == sami wagiaalla <swagiaal@redhat.com> writes:
Sami> This patch creates setters and getters for the newly named
Sami> mangled_lang struct and changes all references to use these functions.
Sami> +extern void
Sami> +symbol_set_demangled_name (struct general_symbol_info *gsymbol, char *name);
In a declaration, we generally don't put a newline after the type.
You can break the line after a "," instead.
Sami> +extern char*
Space before the "*", as well as the line break thing.
This is ok with those changes. Thanks.
I was planning to ask for the new functions to be const-correct, but I
think that would be a big change, since things like symbol_natural_name
return a plain "char *" :-(
Tom