This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Add solib_address and decode_line Python functionality
- From: Tom Tromey <tromey at redhat dot com>
- To: Phil Muldoon <pmuldoon at redhat dot com>
- Cc: Joel Brobecker <brobecker at adacore dot com>, gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Fri, 06 Aug 2010 16:39:01 -0600
- Subject: Re: [patch] Add solib_address and decode_line Python functionality
- References: <4C44728D.4040408@redhat.com> <20100727162545.GF13267@adacore.com> <4C5015E2.4000205@redhat.com> <m3fwz2ja5v.fsf@fleche.redhat.com> <4C5C1418.7030607@redhat.com>
>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
Phil> I looked at the documentation and PY_LONG_LONG is only available on
Phil> some platforms (namely, 64 bit platforms). I used unsigned long, and
Phil> 'k' instead.
I think PY_LONG_LONG should be available in other situations too -- in
particular if the compiler supports "long long", which GCC does.
It is important to use PY_LONG_LONG if it is available. E.g., consider
if gdb is hosted on a 32-bit machine but debugging a 64-bit executable.
In this case an address will be 64 bits.
So, could you make this conditional?
The rest looks good to me.
Tom