This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Add solib_address and decode_line Python functionality
- From: Phil Muldoon <pmuldoon at redhat dot com>
- To: gdb-patches ml <gdb-patches at sourceware dot org>
- Cc: Tom Tromey <tromey at redhat dot com>, Joel Brobecker <brobecker at adacore dot com>, Eli Zaretskii <eliz at gnu dot org>
- Date: Wed, 11 Aug 2010 14:16:02 +0100
- Subject: Re: [patch] Add solib_address and decode_line Python functionality
- References: <4C44728D.4040408@redhat.com> <20100727162545.GF13267@adacore.com> <4C5015E2.4000205@redhat.com> <m3fwz2ja5v.fsf@fleche.redhat.com> <4C5C1418.7030607@redhat.com> <m3d3tvqsca.fsf@fleche.redhat.com> <4C613540.9090009@redhat.com> <m3tyn2comu.fsf@fleche.redhat.com>
On 10/08/10 19:24, Tom Tromey wrote:
>>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
> Eli> This is okay, but I would suggest to explain what happens without the
> Eli> argument first. Readers shouldn't need to read all the description of
> Eli> how the argument is parsed if they don't want to pass it.
>
> Phil> > I've used your re-ordering in this patch, too.
>
> Eli> I'm happy now. Thanks.
>
> Tom> So, could you make this conditional?
>
> Phil> Sure, what do you think of the attached patch?
>
> Tom> Thanks for persevering. This is ok.
So committed. Thanks
http://sourceware.org/ml/gdb-cvs/2010-08/msg00051.html
Cheers,
Phil