This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Add solib_address and decode_line Python functionality


On 10/08/10 19:24, Tom Tromey wrote:
>>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

> Eli> This is okay, but I would suggest to explain what happens without the
> Eli> argument first.  Readers shouldn't need to read all the description of
> Eli> how the argument is parsed if they don't want to pass it.
> 
> Phil> > I've used your re-ordering in this patch, too.
> 
> Eli> I'm happy now.  Thanks.
> 
 
> Tom> So, could you make this conditional?
> 
> Phil> Sure, what do you think of the attached patch?
> 
> Tom> Thanks for persevering.  This is ok.


So committed. Thanks

http://sourceware.org/ml/gdb-cvs/2010-08/msg00051.html

Cheers,

Phil


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]