This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH,Testsuite] Add .align 2 for labels on Thumb

On Mon, Aug 16, 2010 at 08:18:07PM +0200, Mark Kettenis wrote:
> > Date: Mon, 16 Aug 2010 23:39:21 +0800
> > From: "Yao Qi" <yao@codesourcery.com>
> > 
> > > 
> > > Looks fine to me.  Mark, what do you think?
> > 
> > Mark,
> > Is this patch OK to you?
> 
> Sorry, I though I replied to Daniel's message.
> 
> Anyway, I'm afraid I don't understand the problem you're trying to
> fix, so it's hard to say for me that the diff is ok.  However, I'd say
> that 32-bit alignment should be enough; I don't know any architectures
> that have instructions longer than 32-bits and care about alignment.

Yeah, I agree.  Patch is committed.
http://sourceware.org/ml/gdb-cvs/2010-08/msg00098.html
http://sourceware.org/ml/gdb-cvs/2010-08/msg00099.html

-- 
Yao Qi
CodeSourcery
yao@codesourcery.com
(650) 331-3385 x739
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]