This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[patch] Fix new FAIL `reject p 0x1.1' [fixup] [Re: [patch] Handle 0 result from sscanf when parsing fp values.]


[fixup]

On Fri, 20 Aug 2010 09:34:30 +0200, Jan Kratochvil wrote:
Hi,

0x1.1 is a perfectly valid hexadecimal floating point.  The new testcase:
PASS CentOS-4.8 glibc-2.3.4-2.43.el4_8.3
FAIL CentOS-5.5 glibc-2.5-49.el5_5.4
FAIL Fedora 13+14

OK to check-in?


Thanks,
Jan


gdb/testsuite/
2010-08-20  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* gdb.base/printcmds.exp (p 0x1.1): PASS on parse as 1.0625.
	* gdb.java/jv-print.exp (p 0x1.1): PASS on parse as 1.0625.

--- a/gdb/testsuite/gdb.base/printcmds.exp
+++ b/gdb/testsuite/gdb.base/printcmds.exp
@@ -140,7 +140,8 @@ proc test_float_rejected {} {
 
     test_print_reject "p 123foobar.bazfoo3"
     test_print_reject "p 123EEEEEEEEEEEEEEEEE33333k333"
-    test_print_reject "p 0x1.1"
+    # Older glibc does not support hex float, newer does.
+    test_print_reject "p 0x1.1" " = 1\\.0625\r\n"
 
     # Test bad suffixes.
     test_print_reject "p 1.1x"
--- a/gdb/testsuite/gdb.java/jv-print.exp
+++ b/gdb/testsuite/gdb.java/jv-print.exp
@@ -112,7 +112,8 @@ proc test_float_accepted {} {
 
 proc test_float_rejected {} {
     # Test invalid fp values.
-    test_print_reject "p 0x1.1"
+    # Older glibc does not support hex float, newer does.
+    test_print_reject "p 0x1.1" " = 1\\.0625\r\n"
 
     # Test bad suffixes.
     test_print_reject "p 1.1x"


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]