This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/commit] include alloca.h if available.
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: Joel Brobecker <brobecker at adacore dot com>
- Date: Tue, 31 Aug 2010 20:55:40 +0100
- Subject: Re: [RFA/commit] include alloca.h if available.
- References: <1283281511-30193-1-git-send-email-brobecker@adacore.com>
On Tuesday 31 August 2010 20:05:11, Joel Brobecker wrote:
> On LynxOS, alloca is defined in allocal.h. This fixes one warning that
> occurs when building GDBserver for LynxOS.
No objections here. One note.
> gdb/gdbserver/ChangeLog:
>
> * configure.ac: Add configure check for alloca.
> * configure, config.in: Regenerate.
> * server.h: Include alloca.h if it exists.
Every include of malloc.h in gdbserver's common code:
$ grep malloc\\.h *.c
gdbreplay.c:#include <malloc.h>
mem-break.c:#include <malloc.h>
server.c:#include <malloc.h>
tracepoint.c:#include <malloc.h>
utils.c:#include <malloc.h>
win32-low.c:#include <malloc.h>
is there for alloca on mingw32. It might have made
sense to keep those together. I don't really care that
much either way, just pointing it out. :-)
--
Pedro Alves