This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] testsuite: break-entry.exp: convert entry point for ppc64


On Sat, 02 Oct 2010 03:08:22 +0200, emachado@linux.vnet.ibm.com wrote:
> gdb/testsuite/
> 2010-10-01  Edjunior Machado  <emachado@br.ibm.com>
> 	    Luis Machado  <luisgpm@br.ibm.com>
> 
> 	* testsuite/gdb.base/break-entry.exp: convert entry point for
          ^^^^^^^^^^ = excessive.

> 	ppc64 and expect leading `.' on ppc64's symbols


> --- a/gdb/testsuite/gdb.base/break-entry.exp
> +++ b/gdb/testsuite/gdb.base/break-entry.exp

> +if {[istarget powerpc64-*] && [is_lp64_target]} {
> +    set test "convert entry point"
> +    gdb_test_multiple "p *(void(*)(void) *) $entry" $test {
> +	-re " =( \\(\[^0-9\]*\\))? (0x\[0-9a-f\]+)( <.*\[^\r\n\]*)?\r\n$gdb_prompt $" {

There should be either `<\[^\r\n\]*)' or `<.*)' but the combination
`<.*\[^\r\n\]*' has the second part redundant.


>  gdb_breakpoint "main"
> -gdb_continue_to_breakpoint "main" "main.*"
> +gdb_continue_to_breakpoint "main" "\.?main.*"

"\.?main.*" is the same as ".?main.*".  You should use "\\.?main.*" as one
backslash is eaten by the tcl interpreter while the second one by regex.
One can also use {\.?main.*}.


OK with those fixups.


Thanks,
Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]