This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 2/2] Fix overload resolution of int* vs void*
- From: Eli Zaretskii <eliz at gnu dot org>
- To: sami wagiaalla <swagiaal at redhat dot com>
- Cc: tromey at redhat dot com, gdb-patches at sourceware dot org
- Date: Fri, 08 Oct 2010 22:46:38 +0200
- Subject: Re: [patch 2/2] Fix overload resolution of int* vs void*
- References: <4C7BCD42.9070308@redhat.com> <m362yrkgzj.fsf@fleche.redhat.com> <4CAF6B73.5090800@redhat.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Fri, 08 Oct 2010 15:05:23 -0400
> From: sami wagiaalla <swagiaal@redhat.com>
> CC: gdb-patches@sourceware.org
>
> + if (TYPE_NAME (a) && TYPE_NAME (b)
> + && !strcmp (TYPE_NAME (a), TYPE_NAME (b)))
> + return 1;
A minor stylistic nit: can we please use `strcmp (...) == 0' instead
of `!strcmp (...)'? It will produce the same code, but is slightly
more readable.
Thanks.