This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] testsuite: asm-source.exp: build only 32-bit binaries on powerpc
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: Edjunior Barbosa Machado <emachado at linux dot vnet dot ibm dot com>, luisgpm at linux dot vnet dot ibm dot com
- Date: Sat, 16 Oct 2010 18:30:07 +0100
- Subject: Re: [PATCH] testsuite: asm-source.exp: build only 32-bit binaries on powerpc
- References: <1285997194-23908-1-git-send-email-emachado@linux.vnet.ibm.com>
Hi,
On Saturday 02 October 2010 06:26:34, Edjunior Barbosa Machado wrote:
> This patch aims to enforce build only 32-bit executables for the testcase
> on powerpc, in order to avoid errors on ppc64, since the current asm
> source (powerpc.inc) works only for ppc32 (it segfaults on ppc64).
Then you should instead skip the test on ppc64.
> Perhaps a more complete solution for this problem would be a new .inc
> asm file designed for ppc64.
Yes, that would be better.
--
Pedro Alves
> Suggestion/comments are welcome.
> Thanks,
> --
> Edjunior Machado
>
> gdb/testsuite/
> 2010-10-01 Edjunior Machado <emachado@br.ibm.com>
> Luis Machado <luisgpm@br.ibm.com>
>
> * testsuite/gdb.asm/asm-source.exp: ("powerpc*-*") add flags to
> build only 32-bit binaries, since the current powerpc.inc works
> only for ppc32.
> ---
> gdb/testsuite/gdb.asm/asm-source.exp | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/gdb/testsuite/gdb.asm/asm-source.exp b/gdb/testsuite/gdb.asm/asm-source.exp
> index ca342bd..d5022ae 100644
> --- a/gdb/testsuite/gdb.asm/asm-source.exp
> +++ b/gdb/testsuite/gdb.asm/asm-source.exp
> @@ -102,6 +102,8 @@ switch -glob -- [istarget] {
> }
> "powerpc*-*" {
> set asm-arch powerpc
> + set asm-flags "-a32 -mpower4 -I${srcdir}/${subdir} -I${objdir}/${subdir}"
> + append link-flags " -m elf32ppclinux"
> }
> "sh*-*-*" {
> set asm-arch sh
>