This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] skip break-entry.exp when using a stub
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Nathan Froyd <froydnj at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 2 Nov 2010 10:57:55 -0700
- Subject: Re: [PATCH] skip break-entry.exp when using a stub
- References: <1288380040-22077-1-git-send-email-froydnj@codesourcery.com>
> -Nathan
>
> * gdb.base/break-entry.exp: Skip if using a stub.
I am not sure about one detail:
> +# If we're using a stub, we'll already be stopped at the entry point
> +# when we connect. Don't bother trying to work around this in the
> +# testing below.
> +
> +if [target_info exists use_gdb_stub] {
> + untested ${testfile}.exp
> + return
> +}
I am not sure that the use of "untested" is correct, here. Looking
at the dejagnu documentation:
UNTESTED
A test was not run. This is a placeholder, used when there is no
real test case yet.
untested "string"
Declares a test was not run. untested writes in the log file
a message beginning with `UNTESTED', appending the argument
string. For example, you might use this in a dummy test whose
only role is to record that a test does not yet exist for some
feature.
Perhaps we just ought to `return' directly. What do others think?
--
Joel