This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Avoid problems with ptype command
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>, gdb-patches at sourceware dot org
- Date: Tue, 2 Nov 2010 11:33:15 -0700
- Subject: Re: [RFA] Avoid problems with ptype command
- References: <001f01cb6c7f$0693b160$13bb1420$@muller@ics-cnrs.unistra.fr> <20101015171005.GA1729@host1.dyn.jankratochvil.net>
> On Fri, 15 Oct 2010 17:38:33 +0200, Pierre Muller wrote:
> > --- src/gdb/valops.c 8 Oct 2010 16:50:53 -0000 1.252
> > +++ src/gdb/valops.c 15 Oct 2010 10:37:47 -0000
> > @@ -289,7 +289,7 @@ value_cast_structs (struct type *type, s
> > - return value_at (type, addr2);
> > + return value_at_lazy (type, addr2);
>
> Is it easy enough to provide a gdb.pascal/ testcase for this kind of fix?
I agree with Jan that a testcase would be useful. And a comment should
be added next to the change, to explain why we use value_at_lazy and
make sure we don't revert it back to value_at. At the same time,
though, from a conceptual level, should the use of value_at make
such any difference except in terms of performance???
--
Joel