This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] initial OpenCL C language support
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Ken Werner <ken at linux dot vnet dot ibm dot com>
- Cc: Tom Tromey <tromey at redhat dot com>, gdb-patches at sourceware dot org
- Date: Wed, 3 Nov 2010 08:27:23 -0700
- Subject: Re: [patch] initial OpenCL C language support
- References: <201010221920.30046.ken@linux.vnet.ibm.com> <201010271535.05100.ken@linux.vnet.ibm.com> <20101102192311.GI2492@adacore.com> <201011031402.40132.ken@linux.vnet.ibm.com>
> In case of C (and probably Ada as well) the lengths of the builtin
> types depend on the architecuter/implementation but for OpenCL C it's
> kind of the other way round. I hard coded the lengths because OpenCL
> specifies fixed sizes of the builtin types:
> http://www.khronos.org/registry/cl/sdk/1.1/docs/man/xhtml/scalarDataTypes.html
> http://www.khronos.org/registry/cl/sdk/1.1/docs/man/xhtml/vectorDataTypes.html
> Does this sound reasonable?
It took me a while to understand the distinction in the GDB code
between builtin types and primitive types, but I get it, now, and
I understand the reason for the changes - thank you!
Patch looks good to me, at this point. It needs documentation
(doc/gdb.texinfo) and a NEWS entry. Can you send a separate patch
for this portion. Once the documentation is approved, you may commit
this patch as well.
Thank you,
--
Joel