This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdbserver: fix warning in nommu clone
- From: Doug Evans <dje at google dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 15 Nov 2010 18:43:29 -0800
- Subject: Re: [PATCH] gdbserver: fix warning in nommu clone
- References: <1289865042-7691-1-git-send-email-vapier@gentoo.org>
On Mon, Nov 15, 2010 at 3:50 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> Building gdbserver for nommu targets atm fails with:
> ? ? ? ?linux-low.c: In function 'linux_tracefork_child':
> ? ? ? ?linux-low.c:4151: error: pointer of type 'void *' used in arithmetic
>
> So cast the void* to a char*.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>
> 2010-11-16 ?Mike Frysinger ?<vapier@gentoo.org>
>
> ? ? ? ?* linux-low.c (linux_tracefork_child): Add char* cast to arg.
> ---
> ?gdb/gdbserver/linux-low.c | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
> index 7c50251..a81a8dc 100644
> --- a/gdb/gdbserver/linux-low.c
> +++ b/gdb/gdbserver/linux-low.c
> @@ -4148,7 +4148,7 @@ linux_tracefork_child (void *arg)
> ? __clone2 (linux_tracefork_grandchild, arg, STACK_SIZE,
> ? ? ? ? ? ?CLONE_VM | SIGCHLD, NULL);
> ?#else
> - ?clone (linux_tracefork_grandchild, arg + STACK_SIZE,
> + ?clone (linux_tracefork_grandchild, (char *)arg + STACK_SIZE,
> ? ? ? ? CLONE_VM | SIGCHLD, NULL);
> ?#endif
Hi.
Nit: The convention is to put a space after (char *).
Ok with that change.