This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Support -fsplit-stack (previous frame inner to this frame)


>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> +    /* Start and end of the `__morestack' function.  MORESTACK_END address is
Jan> +       the end plus one (exclusive) one.  */

One of the "one"s seems redundant.

Jan> +    CORE_ADDR morestack_start, morestack_end;

Is it impossible for __morestack to appear in multiple objfiles?  What
if you have a program that dlmopen()s two versions of the shared library
defining it?  I don't know how strict we want to be about this kind of
thing -- we don't actually support dlmopen in any meaningful way right
now anyway.

I think this would also need to hook into objfile_relocate.

A new frame type seems like an ok idea.

I don't mind this approach, though I'm also interested to hear what
others think.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]