This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [MI] Duplicate --thread-group flag not detected


>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

>> 2010-11-25  Marc Khouzam  <marc.khouzam@ericsson.com>
>> 
>> * mi/mi-parse.c (mi_parse): Missing else.

Joel> Normally, the man to approve this is Vladimir, so I can't approve, but
Joel> I had a quick look anyway.

I think in this case the patch is simple and obvious enough that we can
go forward without waiting.

What do you think of that?

Joel> Another remark: It looks like the use of the --all/--thread-group/--thread
Joel> options with the -mi-break command is not documented? I could only see
Joel> them documented with commands such as -exec-continue....

This code seems weird to me too.  I suppose it is needed until the
transition to "new" style argv commands is completed.

I was curious about this -- is this sort of transition something people
would want to see done?  Would it help MI users?  (It would help Python
if we ever implemented the automatic MI wrapping... but I am not sure
whether we really want to do that.)

>From what I can see there are 14 such commands.

Joel> Last comment: A small test would be nice...

I agree.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]