Re: [PATCH v4] gdb: bfin: new port

[Mike Frysinger <vapier at gentoo dot org>]

On Wednesday, December 15, 2010 14:17:03 Pedro Alves wrote:
> On Wednesday 15 December 2010 16:47:25, Mike Frysinger wrote:
> > +bfin-*-*)
> > +       # Target: Blackfin
> > +       gdb_target_obs="bfin-tdep.o bfin-linux-tdep.o linux-tdep.o"
> > +       ;;
> 
> should probably be:
> 
> bfin-*-uclinux*)
>        # Target: Blackfin running uclinux
>        gdb_target_obs="bfin-tdep.o bfin-linux-tdep.o linux-tdep.o"
>        ;;
> bfin-*-*)
>        # Target: Blackfin
>        gdb_target_obs="bfin-tdep.o"
>        ;;
> 
> The top-level src/configure.ac seems to actually use
> bfin*-*-uclinux* (extra star).

we run Linux.  uClinux is an old naming.  also, bfin-linux-uclibc is a 
supported target, so i tend to use bfin-*-*linux*.

in the past, any Blackfin gdb was sufficient to debug any Blackfin target, but 
i guess i could preserve this with --enable-targets=... ?

> > +         warning (_("Function Prologue not recognised; pc will point to
> > ENTRY_POINT of the function"));
> 
> way too long line.  write as, e.g.,
> 
>          warning (_("Function Prologue not recognised; "
>                     "pc will point to ENTRY_POINT of the function"));

yes it's long, but i thought the emphasis was on not breaking string literals.  
screws up grep and such.

the rest i've fixed locally
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.