This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 2/3] Implement support for PowerPC BookE ranged watchpoints
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Thiago Jung Bauermann <bauerman at br dot ibm dot com>
- Cc: Pedro Alves <pedro at codesourcery dot com>, gdb-patches at sourceware dot org, Jan Kratochvil <jan dot kratochvil at redhat dot com>, Eli Zaretskii <eliz at gnu dot org>
- Date: Tue, 28 Dec 2010 09:00:42 +0400
- Subject: Re: [patch 2/3] Implement support for PowerPC BookE ranged watchpoints
- References: <1290549100.3164.47.camel@hactar> <201011271747.39053.pedro@codesourcery.com> <1293130182.14239.21.camel@hactar> <201012232017.11120.pedro@codesourcery.com> <1293484743.1544.78.camel@hactar>
> +/* Return true if TYPE is scalar. */
> +
> +int
> +is_scalar_type (struct type *type)
> +{
> + CHECK_TYPEDEF (type);
> +
> + while (TYPE_CODE (type) == TYPE_CODE_REF)
> + {
> + type = TYPE_TARGET_TYPE (type);
> + CHECK_TYPEDEF (type);
> + }
I suggest you make it explicit how TYPE_CODE_REF types are handled.
In certain cases, I think it might be making a difference (a REF
to a struct might have a different classification than the struct
in terms of argument passing, for instance).
--
Joel