This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [patch] Shorten lines of >= 80 columns.
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: "'Michael Snyder'" <msnyder at vmware dot com>, <gdb-patches at sourceware dot org>
- Date: Tue, 4 Jan 2011 20:19:11 +0100
- Subject: RE: [patch] Shorten lines of >= 80 columns.
- References: <4D237089.1080309@vmware.com>
I thought that they were already considered as obvious,
but I still have a remark about one of your
changes:
@@ -632,8 +633,8 @@ gen_var_ref (struct gdbarch *gdbarch, st
break;
case LOC_CONST_BYTES:
- internal_error (__FILE__, __LINE__,
- _("gen_var_ref: LOC_CONST_BYTES symbols are not
supported"));
+ internal_error (__FILE__, __LINE__, _("\
+gen_var_ref: LOC_CONST_BYTES symbols are not supported"));
I think this kind of changes confuses cvs
for the 'cvs diff -u -p':
it might regard the new line
+gen_var_ref: LOC_CONST_BYTES symbols are not supported"));
as a new starting function line and
report a wrong function name...
Of course not really for your example here,
as the start of the line is
the name of the function itself...
But I remember having seen
wrong function name reported with 'cvs -u -p'
due to the use of '_("\'
construct which force starting next line without
spaces...
Pierre Muller
GDB pascal language maintainer
> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Michael Snyder
> Envoyé?: mardi 4 janvier 2011 20:10
> À?: gdb-patches@sourceware.org
> Objet?: [patch] Shorten lines of >= 80 columns.
>
> I would like to propose that this type of change be regarded as
> "obvious".