This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Committed, sim testsuite: fix fallout from copyright year update
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: gdb-patches at sourceware dot org
- Date: Thu, 6 Jan 2011 00:14:20 +0100
- Subject: Committed, sim testsuite: fix fallout from copyright year update
My sim autotester complains about assembly errors in the
mips-elf+mips-sim testsuite. First I thought it was fallout
from recent work on the binutils MIPS port (and some glitch
causing that to go unnoticed in the binutils-for-sim update
phase which would notice this kind of fallout), until I read
sim.log, where the cause is evident:
src/sim/testsuite/sim/mips/testutils.inc: Assembler messages:
src/sim/testsuite/sim/mips/testutils.inc:3: Error: Unrecognized opcode `free Software Foundation,Inc.'
assembler exited with status 1
<humorous free-software-related comment elided>
Committed. Is this a glitch in some copyright-year-update
script or a human error?
A *tested* patch to reformat the copyright lines to whatever
preferred format (IIUC the FSF line should not be "on a line of
its own") would be considered obvious. (I'm working around lack
of knowledge whether Authorized Committer includes approval
rights; I thought at one time it was so, but gdb/MAINTAINERS
says nothing). I think the previous copyright-year update broke
that in some files, but I don't feel a particular urge to fix
it. I'll throw in this missed-update patch, though, also
committed; it might point at a flaw in some script and/or
parameter.
sim/testsuite/sim/mips:
* mips32-dsp.s: Update copyright year.
Index: mips32-dsp.s
===================================================================
RCS file: /cvs/src/src/sim/testsuite/sim/mips/mips32-dsp.s,v
retrieving revision 1.5
diff -p -u -r1.5 mips32-dsp.s
--- mips32-dsp.s 1 Jan 2010 10:03:36 -0000 1.5
+++ mips32-dsp.s 5 Jan 2011 22:59:59 -0000
@@ -4,7 +4,7 @@
#ld: -N -Ttext=0x80010000
#output: *\\npass\\n
-# Copyright (C) 2005, 2010 Free Software Foundation, Inc.
+# Copyright (C) 2005, 2010, 2011 Free Software Foundation, Inc.
# Contributed by MIPS Technologies, Inc. Written by Chao-ying Fu.
#
# This file is part of the GNU simulators.
And the actual fix. My grep didn't find any more related issues
nearby. All tested with --target=mips-elf.
sim/testsuite/sim/mips:
* testutils.inc: Correct comment syntax fallout from
copyright update.
* utils-dsp.inc, utils-fpu.inc, utils-mdmx.inc: Ditto.
Index: testutils.inc
===================================================================
RCS file: /cvs/src/src/sim/testsuite/sim/mips/testutils.inc,v
retrieving revision 1.8
diff -p -u -r1.8 testutils.inc
--- testutils.inc 1 Jan 2011 15:34:07 -0000 1.8
+++ testutils.inc 5 Jan 2011 22:59:59 -0000
@@ -1,6 +1,6 @@
# MIPS simulator testsuite utility functions.
-# Copyright (C) 2004, 2007, 2008, 2009, 2010, 2011
- Free Software Foundation, Inc.
+# Copyright (C) 2004, 2007, 2008, 2009, 2010,
+# 2011 Free Software Foundation, Inc.
# Contributed by Chris Demetriou of Broadcom Corporation.
#
# This file is part of the GNU simulators.
Index: utils-dsp.inc
===================================================================
RCS file: /cvs/src/src/sim/testsuite/sim/mips/utils-dsp.inc,v
retrieving revision 1.8
diff -p -u -r1.8 utils-dsp.inc
--- utils-dsp.inc 1 Jan 2011 15:34:07 -0000 1.8
+++ utils-dsp.inc 5 Jan 2011 22:59:59 -0000
@@ -1,6 +1,6 @@
# MIPS DSP ASE simulator testsuite utility functions.
-# Copyright (C) 2005, 2007, 2008, 2009, 2010, 2011
- Free Software Foundation, Inc.
+# Copyright (C) 2005, 2007, 2008, 2009, 2010,
+# 2011 Free Software Foundation, Inc.
# Contributed by MIPS Technologies, Inc. Written by Chao-ying Fu.
#
# This file is part of the GNU simulators.
Index: utils-fpu.inc
===================================================================
RCS file: /cvs/src/src/sim/testsuite/sim/mips/utils-fpu.inc,v
retrieving revision 1.8
diff -p -u -r1.8 utils-fpu.inc
--- utils-fpu.inc 1 Jan 2011 15:34:07 -0000 1.8
+++ utils-fpu.inc 5 Jan 2011 22:59:59 -0000
@@ -1,6 +1,6 @@
# MIPS simulator testsuite FPU utility functions.
-# Copyright (C) 2004, 2007, 2008, 2009, 2010, 2011
- Free Software Foundation, Inc.
+# Copyright (C) 2004, 2007, 2008, 2009, 2010,
+# 2011 Free Software Foundation, Inc.
# Contributed by Chris Demetriou of Broadcom Corporation.
#
# This file is part of the GNU simulators.
Index: utils-mdmx.inc
===================================================================
RCS file: /cvs/src/src/sim/testsuite/sim/mips/utils-mdmx.inc,v
retrieving revision 1.8
diff -p -u -r1.8 utils-mdmx.inc
--- utils-mdmx.inc 1 Jan 2011 15:34:07 -0000 1.8
+++ utils-mdmx.inc 5 Jan 2011 22:59:59 -0000
@@ -1,6 +1,6 @@
# MIPS simulator testsuite MDMX utility functions.
-# Copyright (C) 2004, 2007, 2008, 2009, 2010, 2011
- Free Software Foundation, Inc.
+# Copyright (C) 2004, 2007, 2008, 2009, 2010,
+# 2011 Free Software Foundation, Inc.
# Contributed by Chris Demetriou of Broadcom Corporation.
#
# This file is part of the GNU simulators.
brgds, H-P