This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Add an evaluation function hook to Python breakpoints.
- From: Doug Evans <dje at google dot com>
- To: pmuldoon at redhat dot com
- Cc: Tom Tromey <tromey at redhat dot com>, gdb-patches at sourceware dot org
- Date: Sun, 9 Jan 2011 12:31:47 -0800
- Subject: Re: [patch] Add an evaluation function hook to Python breakpoints.
- References: <m38vztlr2r.fsf@redhat.com> <AANLkTimS_32d+7phemj95qCSdJzgXXOxjMhbt_9+i8D6@mail.gmail.com> <m34oags1q1.fsf@fleche.redhat.com> <AANLkTimVN=3CKL2VmKWERSmGxiMA7wDv7pMrSQZc1DMO@mail.gmail.com> <m3ipyulpop.fsf@fleche.redhat.com> <AANLkTim_wXWA2OX1GdZ_rFVwBAr+YjO+B5SSVUN_g0vK@mail.gmail.com> <m3fwtq51zj.fsf@fleche.redhat.com> <AANLkTikk03p4m+s0k+UD8RRVy8YL7wYZsLhy2GNc6d8q@mail.gmail.com> <m31v594w65.fsf@fleche.redhat.com> <AANLkTi=b7=b6FZLjLBCZAqcwaAMnYVTTqTB1Z3dOHSd1@mail.gmail.com> <m3sjx7urkv.fsf@fleche.redhat.com> <m3bp3vf6c4.fsf@redhat.com>
On Wed, Jan 5, 2011 at 12:23 PM, Phil Muldoon <pmuldoon@redhat.com> wrote:
> Yeah ultimately this was going to be series of patches (the first being
> this, the ability to write conditions entirely within Python), but the
> whole-story (from these threads) has probably shown we need to think
> about the solution in totality, not incrementally.
I don't mind the incremental approach (fwiw).
There is value in having the stop condition being computed in python.
[As long as we have a clear approach to handling old-style condition
(e.g. break foo if bar) vs new python-style condition.]
It breaks down, I think, in using it for some of the things we've
discussed, but that doesn't diminish the utility of stop_p (or however
it's named).
One thing that may require a non-incremental approach is what kind of
class hierarchy (if any) we want for breakpoints.