This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [toolchain-devel] [PATCH] sim: allow memory maps to default to mapped files
- From: Mike Frysinger <vapier at gentoo dot org>
- To: Doug Evans <dje at google dot com>
- Cc: toolchain-devel at blackfin dot uclinux dot org, gdb-patches at sourceware dot org, Joel Brobecker <brobecker at adacore dot com>
- Date: Tue, 11 Jan 2011 11:04:00 -0500
- Subject: Re: [toolchain-devel] [PATCH] sim: allow memory maps to default to mapped files
- References: <1293426471-5571-1-git-send-email-vapier@gentoo.org> <201012280238.03847.vapier@gentoo.org> <20101228120120.GE2436@adacore.com> <201101082239.10670.vapier@gentoo.org> <AANLkTikYhU0Noq_hc7DJLDDcUThb+ESy1v=kc6Si+f6g@mail.gmail.com>
On Tue, Jan 11, 2011 at 10:07, Doug Evans wrote:
> On Sat, Jan 8, 2011 at 7:39 PM, Mike Frysinger wrote:
>> On Tuesday, December 28, 2010 07:01:20 Joel Brobecker wrote:
>>> OK. ÂThe patch looks good to me, except for the little formatting nits
>>> that I already pointed out. But can you give it a few more days for
>>> others to comment? ÂIn particular, Doug Evans is more proficient with
>>> the simulator than I am, I believe (which is not hard, considering
>>> that I have barely ever touched that code).
>>
>> i'll commit in a day or two if no one has any more feedback ...
>
> Hi. ÂThe only comment I have is that it would be nice to keep "struct
> stat s;" in its original location, but it's not necessary.
i couldnt do that without duplicating the bytes and free_length setup,
and i thought not duplicating those was more important.
-mike