This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Evening up the right margins


Mark Kettenis wrote:
Date: Tue, 11 Jan 2011 19:17:31 -0800
From: Michael Snyder <msnyder@vmware.com>

Mark and Joel, I'm especially interested in your feedback.

This patch is meant to help even up the right margins without adding extra lines to the file. If folks approve, I'll do more.

The thought that comes to my mind is "if it ain't broke, don't fix
it".

That is, of course, a time tested principal.


However, I would argue that nasty-looking margins are a form of breakage. Not as severe as testsuite failures or crashes, but
arguably worthy of fixing.


> I think the benefit from these changes is marginal.

No pun intended, I'm sure. ;-)

Is this
really worth the extra churn in the repository?  It does make diffing
revisions of the affected files more difficult...

I feel that it makes reading the code easier, which is the trade-off.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]