This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC-v2] Fix hpux_major_release variable setting
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 14 Jan 2011 12:04:48 -0500
- Subject: Re: [RFC-v2] Fix hpux_major_release variable setting
- References: <000f01cbb401$1093cdc0$31bb6940$@muller@ics-cnrs.unistra.fr> <20110114163035.GQ2504@adacore.com> <000001cbb40b$b03b3020$10b19060$@muller@ics-cnrs.unistra.fr>
> 2011-01-14 Pierre Muller <muller@ics.u-strasbg.fr>
>
> * solib-som.h (hpux_major_release): Declare variable here.
> * solib-som.c: Remove <sys/utsname.h> header.
> (DEFAULT_HPUX_MAJOR_RELEASE): New macro.
> (hpux_major_release): Make global, change default value to
> DEFAULT_HPUX_MAJOR_RELEASE.
> (get_hpux_major_release): Simply return HPUX_MAJOR_RELEASE.
> * hppa-hpux-nat.c: Add <sys/utsname.h> include.
> Add "solib-som.h" header.
> (set_hpux_major_release): New function.
> (_initialize_hppa_hpux_nat): Call set_hpux_major_release.
I think that's OK, with one minor nit.
> + if (p)
> + hpux_major_release = atoi (p + 1);
> +}
> +
>
>
>
> /* Prevent warning from -Wmissing-prototypes. */
It's a lot of empty lines... While you commit the change, can you
reduce them to just one?
Thanks,
--
Joel