This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 1/2] do not use python<version> subdir when including Python .h file


>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> One last change is the fact that we are now including Python.h
Joel> and all other Python include headers using angle brackets rather
Joel> than double-quotes.  This fixes a problem on case-insensitive
Joel> systems where #include "Python.h" causes our gdb/python/python.h
Joel> header to be included instead of Python's <Python.h> header.

How does this work when srcdir != builddir?  In that case isn't our
python.h found only via a -I option?  Thus causing a clash?

Anyway, this patch looks fine to me.  If the above is a non-issue, go
for it.  If it is an issue, I didn't mind your earlier patch to rename
it to gdb-python.h.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]