This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 1/2] do not use python<version> subdir when including Python .h file


Thanks for looking at the patches, Tom.

> Joel> One last change is the fact that we are now including Python.h
> Joel> and all other Python include headers using angle brackets rather
> Joel> than double-quotes.  This fixes a problem on case-insensitive
> Joel> systems where #include "Python.h" causes our gdb/python/python.h
> Joel> header to be included instead of Python's <Python.h> header.
> 
> How does this work when srcdir != builddir?  In that case isn't our
> python.h found only via a -I option?  Thus causing a clash?

I discovered while working on this that there is actually no -I option
for the gdb/python directory (I thought that we did and I was looking
at that in an attempt to eliminate it).  Files from the gdb/ directory
include our python headers using #include "python/python-internal.h",
while files in the gdb/python/ directory include them more directly
using #include "python-internal.h". 

I do my builds out of tree almost exclusively, I can't remember when
the last time was that I built in-tree. I know that it works in this
case, but I should probably double-check in-tree as well.  I will do
that as soon as I come back from my vacation :-).

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]