This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] Fix for testsuite errors with gdbserver (remote)

From: Keith Seitz <keiths at redhat dot com>
To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
Cc: gdb-patches at sourceware dot org
Date: Fri, 18 Feb 2011 10:49:22 -0800
Subject: Re: [RFA] Fix for testsuite errors with gdbserver (remote)
References: <4D5C71F6.80208@vmware.com> <4D5C7552.4010708@vmware.com> <4D5C8312.4030701@vmware.com> <4D5D6D83.8030302@vmware.com> <4D5D8974.5030205@redhat.com> <000901cbcf8b$a7e35b50$f7aa11f0$@muller@ics-cnrs.unistra.fr>

On 02/18/2011 08:48 AM, Pierre Muller wrote:

   Inverting two lines in remote_close fixes hopefully this issue.
At least using --target_board=native_gdbsderver.exp
works again!

Duh. I didn't even notice the subsequent call to reset inferior_ptid!

I definitely like your patch better than the workaround I posted. Although I do wonder if there are any reasons why we might want to reset inferior_ptid after discard_all_inferiors (notifications?). Nonetheless, I'm the pragmatic sort: if the test suite doesn't reveal such problems, then none exist -- or we'll deal with them when we have hard test cases. :-)

Alas, I am not an ordained maintainer, so someone will still need to officially approve this.

Thank you for following-up on this.

Keith

Follow-Ups:
- Re: [RFA] Fix for testsuite errors with gdbserver (remote)
  - From: Pedro Alves

References:
- [RFA] Fix for testsuite errors with gdbserver (remote)
  - From: Pierre Muller

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]