This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[commit] Document that case statement fall-through is intentional.


Tested with "set debug expression 1" -- and I'm telling you, it took me
a while to figure THAT out!

2011-02-26  Michael Snyder  <msnyder@vmware.com>

	* expprint.c (dump_subexp_body_standard): Document that case
	statement is meant to fall through.

Index: expprint.c
===================================================================
RCS file: /cvs/src/src/gdb/expprint.c,v
retrieving revision 1.50
diff -u -p -u -p -r1.50 expprint.c
--- expprint.c	1 Feb 2011 18:56:34 -0000	1.50
+++ expprint.c	26 Feb 2011 21:48:49 -0000
@@ -767,6 +767,7 @@ dump_subexp_body_standard (struct expres
     case TERNOP_SLICE:
     case TERNOP_SLICE_COUNT:
       elt = dump_subexp (exp, stream, elt);
+      /* FALL THROUGH */
     case BINOP_ADD:
     case BINOP_SUB:
     case BINOP_MUL:
@@ -803,6 +804,7 @@ dump_subexp_body_standard (struct expres
     case STRUCTOP_MEMBER:
     case STRUCTOP_MPTR:
       elt = dump_subexp (exp, stream, elt);
+      /* FALL THROUGH */
     case UNOP_NEG:
     case UNOP_LOGICAL_NOT:
     case UNOP_COMPLEMENT:

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]