This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [commit] linespec.c, decode_line_1, check for null.


On Tuesday 01 March 2011 22:03:22, Michael Snyder wrote:
> Pedro Alves wrote:
> > On Tuesday 01 March 2011 21:43:27, Michael Snyder wrote:
> >> Pedro Alves wrote:
> >>> On Tuesday 01 March 2011 20:57:30, Michael Snyder wrote:
> >>>> If it's worth checking for null, it's worth doing so before the first 
> >>>> dereference.
> >>> Well, then it may not be worth checking for null.  How old is
> >>> that code?  
> >> It predates me, and I've been on gdb since 1995.   ;-)
> > 
> > :-)
> > 
> > Then I think it's safe to say that if we haven't seen
> > a NULL-dereference crash in over 15 years, it's because it's
> > not really necessary.
> > 
> 
> Ok then -- you'd prefer it like this?

Yep.  Thanks.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]