This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] breakpoint.c, create_breakpoint, document that the case statement falls through.
- From: Tom Tromey <tromey at redhat dot com>
- To: Michael Snyder <msnyder at vmware dot com>
- Cc: Joel Brobecker <brobecker at adacore dot com>, "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 03 Mar 2011 10:44:49 -0700
- Subject: Re: [RFA] breakpoint.c, create_breakpoint, document that the case statement falls through.
- References: <4D6EE3D9.2040108@vmware.com> <20110303042652.GU30306@adacore.com> <4D6FCBB1.9040507@vmware.com>
>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
Michael> No, honest, it *does* fall through!
Michael> I had to use a printf statement to convince myself. ;-)
Michael> When the user answers "yes" to the query, it falls through.
Yeah. Your patch is correct, or at least correct-enough.
Adding a "break" would also be correct, because sals.nelts is never 0 at
the end of this case.
Tom