This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [commit] cli/cli-script.c, script_from_file, add a break stmt for lint

From: Michael Snyder <msnyder at vmware dot com>
To: Pedro Alves <pedro at codesourcery dot com>
Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
Date: Fri, 04 Mar 2011 10:21:03 -0800
Subject: Re: [commit] cli/cli-script.c, script_from_file, add a break stmt for lint
References: <4D6EDDBB.9030809@vmware.com> <201103030948.22048.pedro@codesourcery.com> <4D6FD0D1.6000506@vmware.com> <201103031759.21208.pedro@codesourcery.com>

Pedro Alves wrote:

On Thursday 03 March 2011 17:33:05, Michael Snyder wrote:
Please don't. Teach lint about the no-return property of throw_error instead.
       default:
        internal_error (__FILE__, __LINE__, _("bad reason"));
       }
I used "lint" loosely, to mean any checker including a human.
Well, so did I then. :-)

It makes things clearer.
I disagree.

OK then. Reverting this patch.

Follow-Ups:
- Re: [commit] cli/cli-script.c, script_from_file, add a break stmt for lint
  - From: Tom Tromey

References:
- [commit] cli/cli-script.c, script_from_file, add a break stmt for lint
  - From: Michael Snyder
- Re: [commit] cli/cli-script.c, script_from_file, add a break stmt for lint
  - From: Pedro Alves
- Re: [commit] cli/cli-script.c, script_from_file, add a break stmt for lint
  - From: Michael Snyder
- Re: [commit] cli/cli-script.c, script_from_file, add a break stmt for lint
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]