This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.

From: Jeff Law <law at redhat dot com>
To: Tom Tromey <tromey at redhat dot com>
Cc: Michael Snyder <msnyder at vmware dot com>, Tristan Gingold <gingold at adacore dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Fri, 04 Mar 2011 11:41:27 -0700
Subject: Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.
References: <4D70061C.10904@vmware.com> <20110303213008.GY30899@tyan-ft48-01.lab.bos.redhat.com> <4D700F5D.2030109@vmware.com> <807E3430-F4F7-464D-8E8A-527A86BA3D88@adacore.com> <4D712A5F.1040307__35010.4677411311$1299262072$gmane$org@vmware.com> <m3r5amu4tz.fsf@fleche.redhat.com> <4D712F12.8050808__11842.7885965959$1299263268$gmane$org@vmware.com> <m3ipvyu3zw.fsf@fleche.redhat.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/04/11 11:36, Tom Tromey wrote:
> Michael> How come 'xfree' in gdb/utils.c still checks for null?
> 
> I don't know, but I assume just because nobody has bothered to remove
> the check.  I think we also still have code doing `if (x) xfree (x);',
> which is kind of doubly wrong :)
We probably have similar crud in GCC as well; I vaguely recall a
discussion and patches which removed some of this crud, but I doubt it's
all been cleaned up.

jeff
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJNcTJXAAoJEBRtltQi2kC7EboIAJyiVz4y0JXJbydigH2IKHVK
yb13AVw5i6cE4cG4S0WVhOJxyxYVGMX83KzeEqJPLjuEQ45Pb/ePO+eCQkXFPUJM
cDdk1WbcSa/TLd1DpcuJDlcEsD3XgkcZb7snhTwqJts8OOKNmKnCMdb0S5F6alBJ
PeOmhXkk+O4Fw0IwrBH7dhZd6MHwFCzqZFwotEm01lsHKoOh4RYVh4V8ug1VVRCY
bB7XuctXJgdtEyXqg/wjHObsGBViSdO8putOgFATKyedWDxGKKAVWyXK/pNIMX7v
L/PSdm4/H0U0Ku0uDtxuGef4mUE1q5aq+zRWpHA2wNvAvZ1opiDZcaDGP1yeuEw=
=LTVa
-----END PGP SIGNATURE-----

References:
- libiberty/cplus-dem.c, ada-demangle: plug memory leak.
  - From: Michael Snyder
- Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.
  - From: Jakub Jelinek
- Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.
  - From: Michael Snyder
- Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.
  - From: Tristan Gingold
- Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.
  - From: Tom Tromey
- Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]