This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFA] stabsread.c (define_symbol): Guard against bad stabstring input.
- From: Michael Snyder <msnyder at vmware dot com>
- To: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 04 Mar 2011 16:37:25 -0800
- Subject: [RFA] stabsread.c (define_symbol): Guard against bad stabstring input.
I think I heard someone say that gdb should be proof against all inputs?
2011-03-04 Michael Snyder <msnyder@vmware.com>
* stabsread.c (define_symbol): Guard against bad stabstring input.
Index: stabsread.c
===================================================================
RCS file: /cvs/src/src/gdb/stabsread.c,v
retrieving revision 1.136
diff -u -p -r1.136 stabsread.c
--- stabsread.c 28 Feb 2011 23:32:27 -0000 1.136
+++ stabsread.c 5 Mar 2011 00:34:13 -0000
@@ -636,6 +636,9 @@ define_symbol (CORE_ADDR valu, char *str
{
p += 2;
p = strchr (p, ':');
+ if (p == NULL)
+ internal_error (__FILE__, __LINE__,
+ _("Bad stabs string '%s'"), string);
}
/* If a nameless stab entry, all we need is the type, not the symbol.