This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch, arm] Use cached dsc->is_thumb instead of re-computing
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: yao at codesourcery dot com (Yao Qi)
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 7 Mar 2011 17:04:22 +0100 (CET)
- Subject: Re: [patch, arm] Use cached dsc->is_thumb instead of re-computing
Yao Qi wrote:
> > added prototype declaration for displaced_read_reg is now unneeded again.
>
> I guess you mean "displaced_in_arm_mode" here. Removed its declaration.
Yes, sorry, that's what I meant.
> * arm-tdep.c: Remove prototype declaration displaced_in_arm_mode.
> (displaced_read_reg): Add `dsc' parameter, remove `from' parameter.
> Use cached result instead of calling displaced_in_arm_mode again.
> (branch_write_pc, alu_write_pc, load_write_pc): Add `dsc' parameter.
> (displaced_write_reg, copy_preload, copy_preload_reg): Callers update.
> (cleanup_copro_load_store, copy_copro_load_store): Likewise.
> (cleanup_branch, copy_bx_blx_reg, copy_alu_imm): Likewise.
> (cleanup_alu_reg, copy_alu_reg, cleanup_alu_shifted_reg): Likewise.
> (copy_alu_shifted_reg, cleanup_load, cleanup_store): Likewise.
> (copy_extra_ld_st, copy_ldr_str_ldrb_strb): Likewise.
> (cleanup_block_load_all, cleanup_block_store_pc): Likewise.
> (cleanup_block_load_pc, copy_block_xfer): Likewise.
> * arm-linux-tdep.c (arm_linux_copy_svc): Callers update.
> (arm_catch_kernel_helper_return): Likewise.
> * gdb/arm-tdep.h : Update function declarations.
This is OK.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com