This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [revert patch] Remove configure/make in common/
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 9 Mar 2011 08:18:16 +0400
- Subject: Re: [revert patch] Remove configure/make in common/
- References: <4D75FC71.7050301@codesourcery.com>
> gdb/
> 2011-03-08 Yao Qi <yao@codesourcery.com>
>
> Revert:
> 2011-02-11 Yao Qi <yao@codesourcery.com>
>
> * common/Makefile.in: Add copyright header.
>
> 2011-02-11 Yao Qi <yao@codesourcery.com>
>
> * Makefile.in: Remove signals.o from COMMON_OBS. Link
> libcommon.a.
> * configure.ac: Add common to sub dir.
> * configure: Regenerate
>
> gdb/gdbserver/
> 2011-03-08 Yao Qi <yao@codesourcery.com>
>
> Revert:
> 2011-03-04 Yao Qi <yao@codesourcery.com>
>
> * Makefile.in: Remove GNU make feature --directory.
>
> 2011-03-05 Yao Qi <yao@codesourcery.com>
>
> * Makefile.in (CLEANDIRS, REQUIRED_SUBDIRS): New variable.
> (subdir_do): New make target. Copied from gdb/Makefile.
> (maintainer-clean, realclean, distclean, clean): Call corresponding
> make targets in common/Makefile.
>
> 2011-02-11 Yao Qi <yao@codesourcery.com>
>
> * configure.ac: Call AC_PROG_RANLIB.
> * Makefile.in: Remove signals.o from OBS. Link libcommon.a.
> * configure: Regenerate.
This looks good to me. I also did some testing on my own, verifying
the few issues I noticed (Eg. "make configure-gdb; make clean",
very that autoconf, autoheader et al do not get called, etc).
So, let's go ahead and commit.
> @@ -337,6 +331,7 @@ SUBDIR_PYTHON_DEPS =
> SUBDIR_PYTHON_LDFLAGS=
> SUBDIR_PYTHON_CFLAGS=
>
> +
> # Opcodes currently live in one of two places. Either they are in the
This part does not need reverting, though (this is a good example of
why it's better to avoid mixing formatting changes with real changes,
when they are independent).
Thanks a lot, Yao.
--
Joel