This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Implement set/show callback functions in gdb.Parameter
- From: Phil Muldoon <pmuldoon at redhat dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: tromey at redhat dot com, gdb-patches at sourceware dot org
- Date: Thu, 10 Mar 2011 12:09:01 +0000
- Subject: Re: [patch] Implement set/show callback functions in gdb.Parameter
- References: <m3bp2dw9io.fsf@redhat.com> <m3d3mc80js.fsf@fleche.redhat.com> <m34o7ehqht.fsf@redhat.com> <83fwqyhe6y.fsf@gnu.org> <m34o7efz0t.fsf@redhat.com> <83ei6ihd26.fsf@gnu.org>
- Reply-to: pmuldoon at redhat dot com
Eli Zaretskii <eliz@gnu.org> writes:
>> > Calling an operation a "parameter" is not the best idea. Already you
>> > need to talk about "invoking a parameter", which sounds awkward. Can
>> > we find a better word here?
>>
>>
>> Well this is an operation in a gdb.Parameter. Not sure what else to
>> call it. What do you think?
>
> Then how about rephrasing the description like this:
>
> @value{GDBN} will call this method when @var{parameter}'s value has
> been changed via the @code{set} API (for example, @kbd{set foo off}).
>
> Would this be accurate?
>
> For the get_show_string, I would suggest
>
> @value{GDBN} will call this method when @var{parameter}'s
> @code{show} API has been invoked (for example, @kbd{show foo}).
>
> WDYT?
I think it is fine. I'll add the changes that both you and Tom want,
and commit today.
Thanks
Cheers
Phil