This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [commit] Get rid of build warnings on xtensa-tdep.c


> 2011-03-10  Maxim Grigoriev  <maxim2405@gmail.com>
> 
> 	* xtensa-tdep.c (windowing_enabled): Remove inline attribute.
> 	(xtensa_write_register, xtensa_read_register): Likewise.
> 	(xtensa_hextochar): Removed.
> 	(xtensa_init_reggroups): Replace xtensa_hextochar () by explicit code.

Small comments, seen while scanning your patch...

> -static inline void warning_once ()
> +static void warning_once ()

The function name should be on the first column of the line.
This is to facilitate the search of the function implementation
(we can use: <<grep "^warning_once">> for instance). Also,
functions with no arguments should be declared with a "void"
parameter. Thus:

static void
warning_once (void)

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]